KAFKA-19712: Commit OFFSET_UNKOWN when closing state stores and the offsets are not yet initialized#21884
Open
eduwercamacaro wants to merge 1 commit intoapache:trunkfrom
Conversation
…not yet initialized
bbejeck
approved these changes
Mar 30, 2026
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the fix @eduwercamacaro - LGTM with some minor comments
| assertTrue(nonPersistentStore.committed); | ||
|
|
||
| // make sure that flush is called in the proper order | ||
| assertThat(persistentStore.getLastCommitCount(), Matchers.lessThan(nonPersistentStore.getLastCommitCount())); |
Member
There was a problem hiding this comment.
nit: static import for Matchers
|
|
||
| // the checkpoint file should contain an offset from the persistent store only. | ||
| final OffsetCheckpoint storeCheckpoint = new OffsetCheckpoint(storeCheckpointFile); | ||
| final Map<TopicPartition, Long> checkpointedOffsets = storeCheckpoint.read(); |
Member
There was a problem hiding this comment.
This is validating the write path of null to OFFSET_UNKOWN do we want to re-open to confirm that OFFSET_UNKNOWN gets translated back to null?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-19712 got rid of sentinel values when uninitialized offsets were
committed. This made state stores close with invalid offsets when the
store's offsets were not yet initialized.
These changes rollback this decision because it was causing
TaskCorruptedException during rebalances.
Reviewers: Bill Bejeck bbejeck@gmail.com